facebook / winterfell

A STARK prover and verifier for arbitrary computations
MIT License
795 stars 180 forks source link

Change `evaluate_query()` #330

Open Al-Kindi-0 opened 1 month ago

Al-Kindi-0 commented 1 month ago
          Another option is to change `evaluate_query()` to something like:
fn evaluate_query<F, E>(
    &self,
    query: &[F],
    periodic_values: &[F],
    logup_randomness: &[E],
    wires: &mut [CircuitWire],
) where
    F: FieldElement<BaseField = Self::BaseField>,
    E: FieldElement<BaseField = Self::BaseField> + ExtensionOf<F>;

But maybe that's for another PR.

_Originally posted by @irakliyk in https://github.com/facebook/winterfell/pull/324#discussion_r1768941249_