facebook / winterfell

A STARK prover and verifier for arbitrary computations
MIT License
795 stars 180 forks source link

feat(utils): Implement `get_size_hint` for default impls #332

Closed PhilippGackstatter closed 1 month ago

PhilippGackstatter commented 1 month ago

Implements get_size_hint for the types that are implemented by default.

Currently, crates that call u8.get_size_hint() get the default value of 0 which makes it harder to implement get_size_hint for custom types, since they cannot simply call get_size_hint on the contained types recursively. This PR fixes that.

This change is non-breaking.

See also https://github.com/0xPolygonMiden/miden-base/pull/895#pullrequestreview-2326556758 for more context.

facebook-github-bot commented 1 month ago

Hi @PhilippGackstatter!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!