facebook-github-bot
commented
6 months ago This pull request was exported from Phabricator. Differential Revision: D55617689
Closed NickGerleman closed 6 months ago
facebook-github-bot
commented
6 months ago This pull request was exported from Phabricator. Differential Revision: D55617689
vercel[bot]
commented
6 months ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| yoga-website | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 2, 2024 0:11am |
nicoburns
commented
6 months ago There is one bit where I think we are doing the wrong thing wrt alignment of flex start vs start (which we don't support yet), but couldn't repro a failing chrome test.
I believe Chrome is also falling back to flex-start currently (see: https://github.com/servo/servo/pull/31724). I agree with you that this seems to violate the spec, but the spec is currently somewhat inconsistent as it does specify flex-start as the fallback for some alignment modes.
nicoburns
commented
6 months ago CSSWG issue https://github.com/w3c/csswg-drafts/issues/10154
Summary: Gentest tests started failing because Chrome changed behavior of overflowed align-content container. Spec says should fallback to "safe center", which is really just "start", instead of previous "center" behavior. This changes behavior accordingly.
There is one bit where I think we are doing the wrong thing wrt alignment of flex start vs start (which we don't support yet), but couldn't repro a failing chrome test.
Differential Revision: D55617689