search

facebook / yoga

Yoga is an embeddable layout engine targeting web standards.
https://yogalayout.dev/
MIT License
17.25k stars 1.42k forks source link

Make new nodes dirty by default #1641

Closed NickGerleman closed 5 months ago

NickGerleman commented 5 months ago

Summary: Yoga has quirk where newly constructed nodes are clean, which isn't really correct. Normally never shows in in real code because setting a style or children will dirty. Fabric doesn't use the public APIs that do this dirtying, so it ends up getting creative instead.

We should fix so that newly constructed nodes are dirty. Copy-constructed Nodes (also only a Fabric thing, will retain original dirty flag.

Changelog: [Internal]

Differential Revision: D55855328

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **yoga-website** | ⬜️ Ignored ([Inspect](https://vercel.com/fbopensource/yoga-website/H6UDrzQCLrMksbo7FHqdhvMT69G9)) | [Visit Preview](https://yoga-website-git-fork-nickgerleman-export-d-25b07c-fbopensource.vercel.app) | | Apr 10, 2024 4:33am |
facebook-github-bot commented 5 months ago

This pull request was exported from Phabricator. Differential Revision: D55855328

facebook-github-bot commented 5 months ago

This pull request has been merged in facebook/yoga@70de2da05f4cb3e82e7da57938bad12da87c0063.