Implement Percentage support for gap styles - Githubissues

facebook / yoga

Yoga is an embeddable layout engine targeting web standards.

https://yogalayout.dev/

MIT License

17.25k stars 1.42k forks source link

Implement Percentage support for gap styles #1643

Closed realsoelynn closed 5 months ago

realsoelynn commented 5 months ago

Summary: Changelog [Internal]:

Added percentage value for flex layout gap
Wired up to pass proper available width and height to implement this feature

Differential Revision: D56002340

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
yoga-website	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 15, 2024 8:40pm

facebook-github-bot commented 5 months ago

This pull request was exported from Phabricator. Differential Revision: D56002340

facebook-github-bot commented 5 months ago

This pull request was exported from Phabricator. Differential Revision: D56002340

facebook-github-bot commented 5 months ago

This pull request was exported from Phabricator. Differential Revision: D56002340

nicoburns commented 5 months ago

We have some tests for this in Taffy's test suite (search for gap_percentage here: https://github.com/DioxusLabs/taffy/tree/main/test_fixtures/flex). In particular you may want to add tests for the case where the container's size isn't a fixed size, which can require re-resolving the gap size once the container size is computed.

facebook-github-bot commented 5 months ago

This pull request was exported from Phabricator. Differential Revision: D56002340

realsoelynn commented 5 months ago

We have some tests for this in Taffy's test suite (search for gap_percentage here: https://github.com/DioxusLabs/taffy/tree/main/test_fixtures/flex). In particular you may want to add tests for the case where the container's size isn't a fixed size, which can require re-resolving the gap size once the container size is computed.

Thank you so much for the feedback on this. I am looking at how to improve our test cases as well as visualization aspect of it.

facebook-github-bot commented 5 months ago

This pull request was exported from Phabricator. Differential Revision: D56002340

facebook-github-bot commented 5 months ago

This pull request was exported from Phabricator. Differential Revision: D56002340

facebook-github-bot commented 5 months ago

This pull request has been merged in facebook/yoga@cd4a1b8cf63cf09a62d6aefcd16843cc8869488c.