search

facebook / yoga

Yoga is an embeddable layout engine targeting web standards.
https://yogalayout.dev/
MIT License
17.25k stars 1.42k forks source link

Isolate distributed JavaScript #1645

Closed NickGerleman closed 5 months ago

NickGerleman commented 5 months ago

Summary: Right now we publish Yoga by transforming in-place, and rewriting the entrypoint to point to the generated vanilla JavaScript.

It is nice to include the original source, e.g. so that users can use sourcemaps when debugging, but putting these files on top of each other has been causing problems, like https://github.com/facebook/yoga/issues/1637#issuecomment-2049099690

This changes the packaging step to instead put all the outputs into a "dist" folder, and point the package entrypoints there. We still include original source for sourcemap usage.

Test Plan:

Ran yarn prepack and evaluated output.

Differential Revision: D56093470

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yoga-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2024 4:58am
facebook-github-bot commented 5 months ago

This pull request was exported from Phabricator. Differential Revision: D56093470

facebook-github-bot commented 5 months ago

This pull request was exported from Phabricator. Differential Revision: D56093470

facebook-github-bot commented 5 months ago

This pull request was exported from Phabricator. Differential Revision: D56093470

facebook-github-bot commented 5 months ago

This pull request was exported from Phabricator. Differential Revision: D56093470

facebook-github-bot commented 5 months ago

This pull request was exported from Phabricator. Differential Revision: D56093470

facebook-github-bot commented 5 months ago

This pull request has been merged in facebook/yoga@617fd3a6b7dea99a1157e2d478a0fed83d20f270.