search

facebook / yoga

Yoga is an embeddable layout engine targeting web standards.
https://yogalayout.dev/
MIT License
17.1k stars 1.41k forks source link

get/setDirection() bindings missing from Yoga npm version 3.0.4 #1664

Closed Omxjep3434 closed 3 weeks ago

Omxjep3434 commented 1 month ago

Report

Hello Yoga team, I apologize if I'm missing something obvious, but I don't see the bindings for getDirection() and setDirection() in npm version 3.0.4.

It seems this should be included. If I look at the branch compare: https://github.com/facebook/yoga/compare/v3.0.4...main I see this commit on March 12th: https://github.com/facebook/yoga/commit/bd3e3edc753a3357dfaea058d75a241afe4ae53b

However, I don't see these changes in the 3.0.4 src/wrapAssembly.ts file and Javascript indeed throws an error if I call node.getDirection().

I also noticed that setting a direction per node works in the Yoga Playground.

NickGerleman commented 3 weeks ago

It seems this should be included. If I look at the branch compare: https://github.com/facebook/yoga/compare/v3.0.4...main

I think this is looking at the changes that happened since 3.0.4 in main?

It looks like adding the binding did not make the branch cut for 3.0. Though I'm likely going to cut a new minor soon, just matching RN branch cut, which should include this.

Omxjep3434 commented 3 weeks ago

Cool, thanks Nick!