facebook / zstd

Zstandard - Fast real-time compression algorithm
http://www.zstd.net
Other
23.75k stars 2.11k forks source link

Zstandard CLI: Benchmarking Decompress Speed #1537

Closed shakeelrao closed 5 years ago

shakeelrao commented 5 years ago

Not sure if I'm missing something, but shouldn't newDSpeed equal (bench.cSize * TIMELOOP_NANOSEC / dResult.nanoSecPerRun) not (srcSize * TIMELOOP_NANOSEC / dResult.nanoSecPerRun)?

In other words, shouldn't newDSpeed be calculated by the formula size of compressed payload / decompression time? If I'm not mistaken, we're currently calculating size of uncompressed payload / decompression time.

Code snippet here.

(Also, sorry if this isn't the appropriate place to ask this type of question).

shakeelrao commented 5 years ago

My mistake: looks like decompress speed is always calculated based on the uncompressed size, not the compressed size.

Closing this :)