Open nono303 opened 5 months ago
To avoid others having to search: This has been fixed in #4019.
The fix can
The same approach can be used to fix the build for 1.5.6, by adding "-DCMAKE_RC_FLAGS=-I$(pwd)/lib"
(when using powershell, it'd look a bit different with cmd).
Describe the bug CMake build with ninja on MSVC 2022 (vs17) failed with error:
C:\sdk\src\zstd\build\VS2010\libzstd-dll\libzstd-dll.rc(4): fatal error C1083: Cannot open include file: 'zstd.h': No such file or directory
To Reproduce Steps to reproduce the behavior:
git checkout v1.5.6
cmake -G "Ninja" -DCMAKE_INSTALL_PREFIX=C:\sdk\release\vs17_x64-avx2 -DCMAKE_BUILD_TYPE=RelWithDebInfo -DZSTD_LEGACY_SUPPORT=ON -DZSTD_MULTITHREAD_SUPPORT=ON -DZSTD_BUILD_PROGRAMS=OFF -DZSTD_BUILD_CONTRIB=OFF -DZSTD_BUILD_TESTS=OFF -DZSTD_USE_STATIC_RUNTIME=OFF -DZSTD_PROGRAMS_LINK_SHARED=OFF -DZSTD_BUILD_STATIC=OFF -DZSTD_BUILD_SHARED=ON -DBUILD_SHARED_LIBS=ON C:\sdk\src\zstd\build\cmake
ninja.exe -v install
Expected behavior Build success
Desktop (please complete the following information):
-DXXH_NAMESPACE=ZSTD_ -DZSTD_DLL_EXPORT=1 -DZSTD_HEAPMODE=0 -DZSTD_LEGACY_SUPPORT=5 -DZSTD_MULTITHREAD -D_CONSOLE -D_CRT_SECURE_NO_WARNINGS -Dlibzstd_shared_EXPORTS -IC:\sdk\build\vs17_x64-avx2\zstd\lib -IC:\sdk\src\zstd\build\cmake\lib /DWIN32 /D_WINDOWS /w /D_UNICODE /DUNICODE /MD /Zi /Gw /Gy /Zc:inline /O2 /Zf /Zi /FS /GL /MP16 /arch:AVX2 /w /DNDEBUG -DZSTD_DISABLE_ASM /showIncludes
AVX2
Additional context This patch fix the issue