search

facebookarchive / AsyncDisplayKit

Smooth asynchronous user interfaces for iOS apps.
http://asyncdisplaykit.org
Other
13.4k stars 2.2k forks source link

Expected method to read dictionary element not found on object of type 'id<NSObject>' #3313

Open puyangdev opened 6 years ago

puyangdev commented 6 years ago

ASDefaultPlaybackButtonType buttonType = (ASDefaultPlaybackButtonType)[parameters[@"buttonType"] intValue]; UIColor *color = parameters[@"color"];

Expected method to read dictionary element not found on object of type 'id'

ay8s commented 6 years ago

@puyangdev AsyncDisplayKit was renamed to Texture, check out https://github.com/TextureGroup/Texture

avipinto commented 6 years ago

@ay8s there is this pull request opened from August that fixes this issue https://github.com/facebookarchive/AsyncDisplayKit/pull/3310 if @SkyOfFeather didn't sign the https://code.facebook.com/cla maybe you can just make the change? this is a change in the declaration from (id) to (NSDictionary *) Although upgrading to Texture is better but will be harder in big codebase. Thanks

ay8s commented 5 years ago

Unfortunately no PR's will be accepted here. Best to upgrade as theres been years of improvements since. There shouldn't be too many code breaking changes to work through.