search

facebookarchive / BOLT

Binary Optimization and Layout Tool - A linux command-line utility used for optimizing performance of binaries
2.51k stars 176 forks source link

Update skipRelocationProcess #219

Closed yota9 closed 2 years ago

yota9 commented 2 years ago

The ELF::R_AARCH64_TLSDESC_LD64_LO12 and ELF::R_AARCH64_TLSDESC_ADR_PAGE21 relocations might also be relaxed to mov instructions, handle these cases

Also TLS test could be now re-enabled

Vladislav Khmelevsky, Advanced Software Technology Lab, Huawei

rafaelauler commented 2 years ago

Thanks @yota9 ! So, after this diff is applied, the tls test that is marked to fail starts passing, but because it is marked as XFAIL (expected to fail), the test actually returns a non-zero code, which is flagged as a broken test. Could you update that test to remove the XFAIL?

rafaelauler commented 2 years ago

It looks like you already did this, I was checking an old version of your PR. Ignore this.