search

facebookarchive / BOLT

Binary Optimization and Layout Tool - A linux command-line utility used for optimizing performance of binaries
2.51k stars 176 forks source link

[BOLT][TEST] Fix tests #225

Closed ElvinaYakubova closed 2 years ago

ElvinaYakubova commented 2 years ago

This patch relates to issue 224 and adds lit.local.cfg for X86 and AArch64 folders, along with minor fixes in AArch64 tests.

Elvina Yakubova, Advanced Software Technology Lab, Huawei

ElvinaYakubova commented 2 years ago

I've also added a fix for X86 runtime test

rafaelauler commented 2 years ago

Hi Elvina, thanks!

I was wondering if it's possible to check whether LLVM was built with support for that target (for example, checking the string LLVM_TARGETS_TO_BUILD), and then enable the tests based on that, instead of checking the host system?

rafaelauler commented 2 years ago

Nevermind, we still depend on the host system to link startup files that won't be available cross-platform. This solution looks like the best way forward.