search

facebookarchive / BOLT

Binary Optimization and Layout Tool - A linux command-line utility used for optimizing performance of binaries
2.51k stars 176 forks source link

Fix constant islands handling #228

Closed yota9 closed 2 years ago

yota9 commented 2 years ago

After the "Allocate memory for constant islands on-demand" patch there are couple of problems found in constant islands handling:

  1. When creating constant island dependency we need to check that we already allocated IslandInfo for BF.
  2. In ADRRelaxationPass we need to set constant island check under new hasIslandsInfo condition.
  3. In binaryemitter we need to replace hasConstantIsland with hasIslandsInfo check since originally the BF might not have constant island, but might have access to other's BF CI.
yota9 commented 2 years ago

Hello @maksfb @rafaelauler @aaupov ! I would like to ask about possibility of aarch64 testing using your CI. I know that the arm is not facebooks target architecture, but how do you think is it possible to organize the testing using your environment? Thank you!

aaupov commented 2 years ago

Hello @maksfb @rafaelauler @aaupov ! I would like to ask about possibility of aarch64 testing using your CI. I know that the arm is not facebooks target architecture, but how do you think is it possible to organize the testing using your environment? Thank you!

Hi @yota9,

It should be possible to set up ARM testing using GitHub actions with an AArch64 VM. I can take a look at it during the week of Oct 25. It's reasonably straightforward to do, so you're welcome to add it sooner.

yota9 commented 2 years ago

hello @aaupov ! Thank you for your answer! I will be grateful if you will handle this task, since I'm not very deep into gitlab runners & dockers :) But if you won't have time some one from our team probably will handle it, thank you! UPD also the #233 patch currently will be needed to be able to build bolt on aarch64.