facebookarchive / BOLT

Binary Optimization and Layout Tool - A linux command-line utility used for optimizing performance of binaries
2.51k stars 176 forks source link

Aarch64: Add ABS32/16 relocations support #238

Closed yota9 closed 2 years ago

yota9 commented 2 years ago

Add R_AARCH64_ABS32 and R_AARCH64_ABS16 relocations support

Vladislav Khmelevsky, Advanced Software Technology Lab, Huawei

rafaelauler commented 2 years ago

Where is getAbs(size) used?

yota9 commented 2 years ago

@rafaelauler It will be used with golang support, I've just decided to add this function with ABS32/16 relocations support

rafaelauler commented 2 years ago

Unless absolutely necessary, in general we should avoid landing dead code (functions that are not used elsewhere in the codebase). Is it possible to move those functions to the PR that will make use of them?

yota9 commented 2 years ago

@rafaelauler I've removed them from current PR, thanks!