search

facebookarchive / BOLT

Binary Optimization and Layout Tool - A linux command-line utility used for optimizing performance of binaries
2.51k stars 176 forks source link

Fix ShrinkWrapping pop order #251

Closed yota9 closed 2 years ago

yota9 commented 2 years ago

The push and pop instructions might have wrong reorder due to this error. Thanks rafaelauler for the provided test case.

Vladislav Khmelevsky, Advanced Software Technology Lab, Huawei

yota9 commented 2 years ago

Hello @rafaelauler ! The meta-merge-fdata test is failed for some reason, could you please check it? I could not reproduce it on my env, and I don't think it is connected somehow to this patch. Thank you!

rafaelauler commented 2 years ago

Thanks for letting me know, I checked yesterday and I'll push the fix soon.