search

facebookarchive / BOLT

Binary Optimization and Layout Tool - A linux command-line utility used for optimizing performance of binaries
2.51k stars 176 forks source link

BOLT crash in meta-merge-fdata.test #260

Closed aaupov closed 2 years ago

aaupov commented 2 years ago

BOLT is crashing in the open-source testing: https://github.com/facebookincubator/BOLT/runs/4391355414?check_suite_focus=true#step:3:4050

BOLT-WARNING: split function detected on input : malloc_init_hard_a0_locked.cold/1. The support is limited in relocation mode.
...
llvm-bolt: /home/bolt/llvm-bolt/bolt/lib/Core/BinaryContext.cpp:1102: void llvm::bolt::BinaryContext::registerFragment(llvm::bolt::BinaryFunction&, llvm::bolt::BinaryFunction&) const: Assertion `TargetParent == &Function && "mismatching parent function"' failed.

The issue is with split functions in the input binary. Might be related to the issue #245

aaupov commented 2 years ago

Fixed by bb156d9abbf21a0c7d94ae9a402dc05a4bbff2f7