facebookarchive / CommunityCellularManager

Tool for deploying, managing and controlling your Community Cellular Networks
Other
88 stars 36 forks source link

[cloud] Added git support to fabric #26

Closed matt9j closed 7 years ago

matt9j commented 7 years ago

Summary: Allow fabric to fall back to git if a mercurial repo is not found or mercurial is not installed. This is needed for a real deployment of the git based public projected. As with the previous pull request, please let us know what the standards are for community pull requests if there is anything we should update or change! Cheers, -mj

9muir commented 7 years ago

Cool, nice addition. I'd probably refactor it a little, see inline comments.

facebook-github-bot commented 7 years ago

@9muir has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot commented 7 years ago

@matt9j updated the pull request - view changes - changes since last import

matt9j commented 7 years ago

@9muir Sorry it took so long for me to get back to this-- it was a busy last quarter :sweat_smile: I believe I took your comments into account and updated the original patch from Kurtis. Let me know if there's anything else you see that I should update!

facebook-github-bot commented 7 years ago

@matt9j updated the pull request - view changes - changes since last import

matt9j commented 7 years ago

Looks good @matt9j, just some minor stylistic nits.

Thanks for the style tips-- I'm still getting back into writing professional python from C++. I'll address them in a single style update commit!

facebook-github-bot commented 7 years ago

@matt9j updated the pull request - view changes - changes since last import

facebook-github-bot commented 7 years ago

@9muir has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

9muir commented 7 years ago

Thanks @matt9j, looks good. Will accept to our internal repo, which will get synced and close this out.

matt9j commented 7 years ago

Thanks @matt9j, looks good. Will accept to our internal repo, which will get synced and close this out.

:+1: