search

facebookarchive / CommunityCellularManager

Tool for deploying, managing and controlling your Community Cellular Networks
Other
87 stars 36 forks source link

Fix cert server on ubuntu/trusty32 #27

Closed mferland closed 7 years ago

mferland commented 7 years ago

When setting the vm.box to "ubuntu/trusty32" the cert server fails complaining about a missing file. Turns out the architecture was hard-coded to amd64 in some filenames. This patch adds a step to determine the architecture dynamically. Tested on ubuntu/trusty32.

facebook-github-bot commented 7 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

9muir commented 7 years ago

Looks good at first glance. Once you sign the CLA we can easily get that merged.

Thanks for contributing!

facebook-github-bot commented 7 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot commented 7 years ago

@9muir has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

9muir commented 7 years ago

Thanks Marc, verified that this works well for both 32- and 64-bit targets. Just turning the crank to accept it into our repo.