search

facebookarchive / CommunityCellularManager

Tool for deploying, managing and controlling your Community Cellular Networks
Other
87 stars 36 forks source link

CCM Enhancement sprint1 #31

Closed piyushabad88 closed 7 years ago

piyushabad88 commented 7 years ago

Request you to review the Sprint 1 changes. Following requirements are covered in this Sprint:

  1. User Management
    • Create User
    • Delete User
    • Block / Unblock User
  2. Subscriber Management
    • Categorize IMSI
facebook-github-bot commented 7 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

facebook-github-bot commented 7 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

9muir commented 7 years ago

Thanks. It would be better if you could group these by logical changes rather than having one giant PR for the entire sprint. Please try to minimise whitespace changes too. I've added a few comments based upon a cursory review.

facebook-github-bot commented 7 years ago

@aricent-ccm updated the pull request - view changes