Network balance limit (Client dependent)

facebookarchive / CommunityCellularManager

Tool for deploying, managing and controlling your Community Cellular Networks

Other

87 stars 36 forks source link

Network balance limit (Client dependent) #38

Open shivkumarsah opened 7 years ago

shivkumarsah commented 7 years ago

Please review network/subscriber credit limit implementation which include the below features:

Cloud admin and admin have rights to set the highest denomination bracket (Reload limit) correspond to which subscriber can do top up.
Cloud admin and admin have rights to set the maximum balance limit a subscriber can have. Retailer cannot transfer more than the set balance limit amount to any subscriber.
Subscribers can not have the account balance greater than the set balance limit.
Cloud admin and admin have rights to set the limit on maximum number of consecutive unsuccessful transactions.

facebook-github-bot commented 7 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

facebook-github-bot commented 7 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot commented 7 years ago

@shivkumarsah updated the pull request - view changes

kkroo commented 7 years ago

Careful to split out reviews. I think this also contained #39

facebook-github-bot commented 7 years ago

@shivkumarsah updated the pull request - view changes

facebook-github-bot commented 7 years ago

@shivkumarsah updated the pull request - view changes

facebook-github-bot commented 7 years ago

@shivkumarsah updated the pull request - view changes

kkroo commented 7 years ago

is this ready for review?

piyushabad88 commented 7 years ago

yes , please review.As suggested comments are incorporated.

facebook-github-bot commented 7 years ago

@shivkumarsah updated the pull request - view changes

facebook-github-bot commented 7 years ago

@shivkumarsah updated the pull request - view changes

facebook-github-bot commented 7 years ago

@9muir has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

9muir commented 7 years ago

Please address comments from our internal linter:

If you rebase against the current head then three of the F401 errors should go away (I fixed them in a commit recently).

facebook-github-bot commented 7 years ago

@shivkumarsah updated the pull request - view changes - changes since last import

facebook-github-bot commented 7 years ago

@9muir has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.