facebookarchive / CommunityCellularManager

Tool for deploying, managing and controlling your Community Cellular Networks
Other
87 stars 36 forks source link

Fb/osmocom working #59

Closed kheimerl closed 7 years ago

kheimerl commented 7 years ago

contains fixes to #58 and an issue with the openvpn package. With this in place (and the other workarounds) I got an osmocom vm up and running.

kheimerl commented 7 years ago

So should I convert this to include just the removal of the smpp build and the openvpn change?

9muir commented 7 years ago

confirm that the change I pushed works for you too (I did test, but just to be sure). I'm happy with either removing the smpp build or leaving it as it now is, whichever you and @kkroo prefer, just don't have something commented out. The OpenVPN change is the most useful.

kheimerl commented 7 years ago

i can't test the diff, I work off the open source repo :( I'l let omar call that ball.

On Thu, Jun 15, 2017 at 12:10 PM, Steve Muir notifications@github.com wrote:

confirm that the change I pushed works for you too (I did test, but just to be sure). I'm happy with either removing the smpp build or leaving it as it now is, whichever you and @kkroo https://github.com/kkroo prefer, just don't have something commented out. The OpenVPN change is the most useful.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/facebookincubator/CommunityCellularManager/pull/59#issuecomment-308838902, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_rn2yucn3eb1eVt-TTuduJp07uU7Ulks5sEYGcgaJpZM4N6YO5 .

kkroo commented 7 years ago

I like what @9muir did in making freeswitch build only if you have the source checkout out. Let's use the internal diff. Closing this out

9muir commented 7 years ago

@kheimerl the change is pushed to the open source repo as 443fa69

9muir commented 7 years ago

we want the OpenVPN change, can you ( @kheimerl ) just remove the other commit from this PR and reopen it?