Closed iedemam closed 8 years ago
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
Thanks, that looks pretty good. Will push it through our internal workflow
Bug details are in issue #6. Re-confirmed broken on 2983c8ce9c7dcd84359f03164c37156acde44988 and verified fixed using this single change.
To avoid triggering any unexpected side-effects from mixing locales, I chose to include all variables even if they are overkill (e.g.
LC_PAPER
).