search

facebookarchive / CommunityCellularManager

Tool for deploying, managing and controlling your Community Cellular Networks
Other
87 stars 36 forks source link

[osmocom-python] Explicitly track development requirements #97

Closed matt9j closed 6 years ago

matt9j commented 6 years ago

This commit explicitly tracks common developer packages (nose and mock) to allow for automated continuous integration of osmocom-python's tests.

shaddi commented 6 years ago

Thanks for this PR. Could you please update these to >= dependencies? I think tracking base requirements is good, but I'm not sure they need to be specifically tied to these versions.

facebook-github-bot commented 6 years ago

@matt9j has updated the pull request. View: changes

matt9j commented 6 years ago

@shaddi Updates have been made! The versions I pinned were not chosen specifically, but just happen to be the versions most up to date on pypi right now. Older versions could probably be used as the requirement, but I didn't taken the time to go back and see what features are specifically required by the module. I have tested with these versions on my local machine and on Travis, so base-lining here should be okay going forward.

shaddi commented 6 years ago

Awesome, thanks! I know pip freeze uses == by default for good reason, but I think it's better to be flexible here.

matt9j commented 6 years ago

Definitely. I've been using pipenv/pipfiles internally, and they differentiate between the predictability of freeze and the flexibility of specifying softer dependencies. It's a nice upgrade over the default requirements files, but not standardized yet.