search

facebookarchive / FBMemoryProfiler

iOS tool that helps with profiling iOS Memory usage.
Other
3.41k stars 377 forks source link

Only invoke `memoryProfilerDidFindRetainCycles:` delegate methods if count > 0 #17

Closed Buju77 closed 8 years ago

Buju77 commented 8 years ago

Only invoke method when found retain cycle count > 0. Previously it was also invoked when count == 0.

ghost commented 8 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

ghost commented 8 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

kastiglione commented 8 years ago

Thanks. Looks good to me. @Gricha are you 👍 too?

Gricha commented 8 years ago

Yes, let's merge that in!