search

facebookarchive / Keyframes

A library for converting Adobe AE shape based animations to a data format and playing it back on Android and iOS devices.
https://facebookincubator.github.io/Keyframes/
Other
5.33k stars 302 forks source link

Android: explain need for imageView.setImageAlpha(0) #105

Open BoD opened 7 years ago

BoD commented 7 years ago

Hi!

On Android, in order for the graphics to be correctly rendered, imageView.setImageAlpha(0); must be called on the ImageView.

This is confusing because one would expect this line to make the ImageView completely transparent!

The reason for this should be explained on the main page, or somewhere else, to avoid any confusion.

Related issues: #47 #61 #63

BoD commented 7 years ago

Also, Keyframes has a minSdkVersion of 15, but setImageAlpha exists since 16. Even more confusion because of that :)

lozzle commented 7 years ago

It was a fix for https://github.com/facebookincubator/Keyframes/issues/47, which I wasn't able to repro on my devices.

I wasn't aware setImageAlpha is API 16, so we should add a version check there

pinkred commented 7 years ago

I used ImageView.setBackgroundColor().