search

facebookarchive / Keyframes

A library for converting Adobe AE shape based animations to a data format and playing it back on Android and iOS devices.
https://facebookincubator.github.io/Keyframes/
Other
5.34k stars 302 forks source link

Update AfterEffects and iOS Keyframes to Support XY Rotation #110

Open jacksontaylor13 opened 7 years ago

jacksontaylor13 commented 7 years ago

After Effects Script: Added in functionality to support the XY rotation on a 3D layer in After Effects. If you perform the transformation on the Transform of the Shape Layer you will be able to animate the 3-D axes also. Currently the support is only for Z-axis rotation, so this PR will add in the new functionality. In the Keyframes file, once exported, the keys used for X and Y rotation are X_ROTATION and Y_ROTATION, respectively.

iOS SDK: In order to interpret and handle the new 3D layer transformations, the iOS SDK will now be able to intepret the values and insert the animations accordingly. Using a new KFAxis enumeration on the KFVectorAnimationLayer class, you are able to specify which axis the rotation animation should occur on. This will hopefully help abstract some of the code in that file, to prevent duplication.

jacksontaylor13 commented 7 years ago

Since this PR deals with rotation, also included a fix for issue #106.

facebook-github-bot commented 7 years ago

@jacksontaylor13 updated the pull request - view changes

facebook-github-bot commented 7 years ago

@LazyChild has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot commented 7 years ago

@jacksontaylor13 updated the pull request - view changes - changes since last import

facebook-github-bot commented 7 years ago

@LazyChild has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

kjhgg commented 6 years ago

Hf