facebookarchive / Keyframes

A library for converting Adobe AE shape based animations to a data format and playing it back on Android and iOS devices.
https://facebookincubator.github.io/Keyframes/
Other
5.33k stars 302 forks source link

iOS Dynamic Framework improvements #58

Closed marmelroy closed 7 years ago

marmelroy commented 7 years ago

Hello,

I am using Keyframes in a Swift-only project and encountered a number of issues when integrating it as a dynamic framework - the most significant being the fact that the project didn't have a public header.

This PR solves the following:

marmelroy commented 7 years ago

Thanks for the quick feedback @LazyChild. I made three of the four requested changes.

marmelroy commented 7 years ago

So the real issue was the way that the Swift sample project was set up. It's now fixed and the PR uses #import <Keyframes/[public class].h> everywhere.