macOS compatibility - Githubissues

facebookarchive / Keyframes

A library for converting Adobe AE shape based animations to a data format and playing it back on Android and iOS devices.

https://facebookincubator.github.io/Keyframes/

Other

5.33k stars 302 forks source link

macOS compatibility #64

Closed insidegui closed 7 years ago

insidegui commented 7 years ago

Related issue: #39

Adding support for macOS was quite simple since the framework uses Core Animation which is the same between iOS and macOS :)

Here's what I have done:

Created a compatibility header to import the correct frameworks when building on macOS vs iOS
Added categories to NSBezierPath, NSImage and NSValue implementing some features used by keyframes which were not available on macOS
Updated the Podspec to support macOS
Added sample projects for macOS (Swift and Objective-C)

I've used the sample logo for testing, it looks exactly the same between iOS and macOS. Tested both manual integration and using CocoaPods, both work.

insidegui commented 7 years ago

FYI: I've also created a little document-based app to be able to easily open .json animations for testing :)

renyu-io commented 7 years ago

Thank you so much @insidegui. This is really exciting!

Headers should be updated
All files under DataModel/ are auto-generated. In theory we shouldn't modify them, but I don't see an easy way to change the script for our compatibility usage. It might make sense to maintain the data model manually from now on.
Also code need rebase

insidegui commented 7 years ago

I will implement the changes tomorrow and update the PR.

insidegui commented 7 years ago

Squashed and rebased :)

I've also implemented the framework improvements from #58 on the macOS target.

renyu-io commented 7 years ago

Thank you @insidegui. One last thing, objc sample app won't compile since we renamed the framework to capital K.

skagedal commented 7 years ago

If remodel is indeed not to be used any longer, may I suggest that the "auto-generated" comments are removed/changed? I was about to prepare a little pull request, installed remodel-gen and was surprised to see that it didn't generate the same files.