search

facebookarchive / Keyframes

A library for converting Adobe AE shape based animations to a data format and playing it back on Android and iOS devices.
https://facebookincubator.github.io/Keyframes/
Other
5.33k stars 302 forks source link

Added finished parameter in KFVectorLayer’s animationDidStopBlock #77

Closed x401om closed 7 years ago

x401om commented 7 years ago

I just added finished parameter to the animationDidStopBlock to be sure, animation was really finished (because this block is called at least twice).

facebook-github-bot commented 7 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

facebook-github-bot commented 7 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot commented 7 years ago

@x401om updated the pull request - view changes

facebook-github-bot commented 7 years ago

@x401om updated the pull request - view changes

facebook-github-bot commented 7 years ago

@x401om updated the pull request - view changes

renyu-io commented 7 years ago

@x401om Thank you for the changes, looks pretty good

facebook-github-bot commented 7 years ago

@LazyChild has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.