search

facebookarchive / Keyframes

A library for converting Adobe AE shape based animations to a data format and playing it back on Android and iOS devices.
https://facebookincubator.github.io/Keyframes/
Other
5.33k stars 302 forks source link

More (advanced) JSON example files #80

Closed m1ga closed 7 years ago

m1ga commented 7 years ago

Are there any examples beside the keyframes logo JSON to try out? E.g. the emoticons?

I don't have access to AFX to create files but I would like to test more files on Android (I'm creating an Android module for Appcelerator Titanium: https://github.com/m1ga/ti.keyframes to support Keyframes) to see if everything is running fine.

thewoodpecker commented 7 years ago

@m1ga I created a few animated emoji and they worked well on iOS. The JSON files are here - https://www.dropbox.com/s/8cyy15gdc7s6gtu/smileys.zip?dl=0

Not sure if this is what you're after but I hope it helps.

emoji-prediction

m1ga commented 7 years ago

@thewoodpecker thanks a lot 👍 Exactly what I was looking for. Running nice and smoothly!

Now I have to see if I can parse the canvas_size correctly to make it use this if you don't set a height/width in the framework.

A resource for free/paid animations would be fine if Keyframes gets used by a lot of people

lozzle commented 7 years ago

@thewoodpecker this is awesome! i'm working on throwing together a github io page, and currently just have the keyframes logo as a sample resource. do you mind if i throw this in that list as well?

https://facebookincubator.github.io/Keyframes/docs/sample-files

thewoodpecker commented 7 years ago

@m1ga no worries, glad it was what you needed 👍 @lozzle that would be great. I've included the AFX and json files in the link - https://www.dropbox.com/s/39baqx8dwzhy0ce/smileys.zip?dl=0

Great work on Keyframes btw. I'm a designer and have been saying for ages there should be a tool like this!

Audiobrad commented 7 years ago

Has anyone been able to get a json file to work accurately that doesn't have a 1:1 canvas size?

Everything we have tested at a different aspect ratio is squished and only renders correct when the x & y are the same value

m1ga commented 7 years ago

@Audiobrad the file @thewoodpecker posted is 148x54 and looking fine: gif (sorry for the low quality) But I've set the ImageView size to exactly that size. Did you mean x and y have the same value as x and y of the source file or did you mean x == y ?

lozzle commented 7 years ago

Hi @Audiobrad, are you still having issues with x/y canvas scaling? We've had some problems in the past on Android due to the way scaling is done in some comps, but I think we've addressed most of them. If you have a comp or exported file that shows the issues we can take a look at, we might be able to help debug it.

hansemannn commented 7 years ago

Hey guys! I created keyframes-collection to collect useful keyframes :-) @thewoodpecker Can I add your icons as well? And if so, under which License and credits? Feel free to do a PR! It a completely non-commerical list.

@lozzle Do we want this to be included in the readme as well?

lozzle commented 7 years ago

Yep @hansemannn, I can refer to this in the github.io! We maybe could consolidate the two lists, since the github.io page is open for PR also.

Audiobrad commented 7 years ago

@lozzle @m1ga thanks for the replies. it sounds like the issues we were having were on our end and based on the container that was created for the animation.

lozzle commented 7 years ago

Closing this out, we should move any more advanced examples to the github io: https://facebookincubator.github.io/Keyframes/docs/sample-files