search

facebookarchive / Keyframes

A library for converting Adobe AE shape based animations to a data format and playing it back on Android and iOS devices.
https://facebookincubator.github.io/Keyframes/
Other
5.33k stars 302 forks source link

Android: add playOnce() #94

Closed m1ga closed 7 years ago

m1ga commented 7 years ago

Add playOnce() that will play the animation only once and stops at the end

facebook-github-bot commented 7 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

facebook-github-bot commented 7 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot commented 7 years ago

@m1ga updated the pull request - view changes

hansemannn commented 7 years ago

@m1ga Should I do the iOS one? ☺️ And what's the difference to stopAnimationAtLoopEnd ?

m1ga commented 7 years ago

@hansemannn go ahead 😄 . The stopAnimationAtLoopEnd() will just set a boolean value so it will stop at the end. So you have to start it first by hand and wait some ms to set it. It's a workaround to playOnce() but too many lines to type ;)

hansemannn commented 7 years ago

iOS-PR: https://github.com/facebookincubator/Keyframes/pull/95

facebook-github-bot commented 7 years ago

@lozzle has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.