facebookarchive / RakNet

RakNet is a cross platform, open source, C++ networking engine for game programmers.
Other
3.3k stars 1.02k forks source link

CMake quoting "fix" breaks future versions of MSVC #32

Open jaynus opened 9 years ago

jaynus commented 9 years ago

At Lib/LibStatic/CMakeLists.txt#L20 there is a hotfix to work around windows quoting issues, which conditional checks "some" vs compilers, which is a bit too restrictive. IF( MSVC10 OR MSVC11 OR MSVC12 )

For VS2015 preview, which is build chain MSVC14, and any future MSVC's this will require additions to fix this. This causes the build to fail on the incorrect quote escaping.

The majority of the build system is already assuming MSVC chain on windows for definitions and arguments, the same should be assumed for these quoting mechanisms

IF(WIN32 AND NOT UNIX)

instead.