search

facebookarchive / RakNet

RakNet is a cross platform, open source, C++ networking engine for game programmers.
Other
3.3k stars 1.02k forks source link

Eliminated a G++ warning (invalid conversion from const char* to char*) #61

Open 48656c6c6f opened 9 years ago

Luke1410 commented 7 years ago

The change to Source/NatPunchthroughClient.cpp (char -> const char) is a duplicate of #22 and is integrated in https://github.com/SLikeSoft/SLikeNet (incorporated in SLikeNet 0.1.0).

The remaining pull request was rejected since it appears to have applied the outcome of some static code analysis results blindly without proper review. For instance initialization of members in private cpy-ctors was added which are just declared private in the original code in order to disallow copying the instances.

If you believe the conclusion is in inappropriate, please let us know.

Luke1410 commented 7 years ago

Due to lack of a different way to reach out to you, I'm adding this one as a comment to your pull request:

Since we incorporated (part of) your pull request in SLikeNet, we'd like to offer you to be added to the acknowledgement section in the accompanying readme file.

By default the entry would look like: Brian Curtis: https://github.com/briancurtis (pull request: RAKPR_61)

Please let me know (preferably by email) if we'd add such an entry in the next release of SLikeNet for you (and in case you'd prefer a different style, how it should look like). If there's no reply from your side, we'll not add such an entry to respect your privacy. Note that for those who decided not to be listed in the acknowledgement section and/or those we failed to contact, we added the following generic statement to cover these contributions: "We'd also like to thank those contributors who have requested to remain anonymous and/or those who we could not contact at all (due to lack of contact information)."