search

facebookarchive / RakNet

RakNet is a cross platform, open source, C++ networking engine for game programmers.
Other
3.3k stars 1.02k forks source link

Fixes build errors in MSVC 2014/2015 compiling with latest CMake #64

Open jaynus opened 9 years ago

jaynus commented 9 years ago

References: #32

The latest version of CMake support MSVC14 (Visual Studio 2014/2015 CTP). Raknet fails to build in these circumstances due to version-specific MSVC checks, as well as STL changes due to c++11/14 implementations in MSVC.

These fix the ambiguity errors present in new MSVC STL implementation and adds latest MSVC to build system.

Xitano commented 9 years ago

thank you.. i'll try again and i say the result..

Xitano commented 9 years ago

perfect!

jaynus commented 9 years ago

Now if only PRs ever got merged :p

mbabuskov commented 8 years ago

Using std::abs creates a linker problem with clang if you try to simply compile RakNet sources as a part of a program that uses std::string. There's another patch here on github that uses fabs() instead of std::abs(). I'm not sure about the original purpose of abs()? Is fabs() a valid solution?

Luke1410 commented 7 years ago

Pull request integrated in https://github.com/SLikeSoft/SLikeNet (incorporated in SLikeNet 0.1.0).

Luke1410 commented 6 years ago

Due to lack of a different way to reach out to you, I'm adding this one as a comment to your pull request:

Since we incorporated your pull request in SLikeNet, we'd like to offer you to be added to the acknowledgement section in the accompanying readme file.

By default the entry would look like: jaynus: https://github.com/jaynus (pull request: RAKPR_64)

Please let me know (preferably by email) if we'd add such an entry in the next release of SLikeNet for you (and in case you'd prefer a different style, how it should look like). If there's no reply from your side, we'll not add such an entry to respect your privacy. Note that for those who decided not to be listed in the acknowledgement section and/or those we failed to contact, we added the following generic statement to cover these contributions: "We'd also like to thank those contributors who have requested to remain anonymous and/or those who we could not contact at all (due to lack of contact information)."