Update CMake files to follow standard conventions

facebookarchive / RakNet

RakNet is a cross platform, open source, C++ networking engine for game programmers.

Other

3.3k stars 1.02k forks source link

Update CMake files to follow standard conventions #86

Closed JohnMH closed 7 years ago

JohnMH commented 8 years ago

This change builds the shared library on Linux as "libraknet.so" instead of "libRakNetDLL.so".

On Linux, it is common for library names to be lowercase, and the removal of "DLL" is done for a pretty obvious reason. It's certainly not a DLL on Linux, is it?

Luke1410 commented 6 years ago

I understand this PR is related to this commit: https://github.com/JohnMH/RakNet/commit/91271a390a7bb3708708fbc0d1de2594c1f8cd7f

Was there a particular reason you rejected the PR? Certainly this would cause trouble for existing installations (library name change), but IMO this is certainly a reasonable change (adding it to the list of changes we'll consider for SLikeNet 2.0.0 - upon request will consider for integration in 0.2.0 though - internal case number SLNET-189).

JohnMH commented 6 years ago

@Luke1410 The PR was closed automatically by GitHub, it seems. To be clear, I have no idea what SLikeNet is.

Luke1410 commented 6 years ago

@JohnMH, thanks for clarifying. SLikeNet is our fork of RakNet: https://www.slikesoft.com/?page_id=259&lang=en / https://github.com/SLikeSoft/SLikeNet