search

facebookarchive / RakNet

RakNet is a cross platform, open source, C++ networking engine for game programmers.
Other
3.3k stars 1.02k forks source link

FIXED MakeSwig.bat creates output + copy directories if needed #93

Open kdavison opened 8 years ago

kdavison commented 8 years ago

Had issue in MSVS 2015 Community where MakeSwig.bat did not create directories as needed. Fixed MakeSwig.bat by creating some variables for the output / copy directories and creating those directories if they did not exist.

AnsonKindred commented 8 years ago

I had this problem as well. I believe it's also a problem in the linux version of the script.

Luke1410 commented 6 years ago

@kdavison: Due to lack of other means to contact you, posting this here as a comment:

I understand that you didn't put your pull request under a special license and hence in our understanding it's covered by the original RakNet license. Please let me know if I got this wrong and you rather considering your contributions under special license terms.

We applied the basic idea of your pull request in SLikeNet (internal case number: SLNET-193 - available already in the GitHub and SVN repositories - changes are scheduled to be shipped in SLikeNet 0.2.0: https://github.com/SLikeSoft/SLikeNet )

As a way to thank you for your contribution, we'd like to offer you putting you in the acknowledgments section of the accompanying readme for the next version:

kdavison: https://github.com/kdavison (pull request: RAKNET_93)

Please let me know if that's fine with you (preferably by mail to info [at] slikesoft [dot] com - or alternatively leave a comment here). Unless you explicitly say so, we won't put that entry in the readme file (to respect your privacy).

kdavison commented 6 years ago

I believe I made it using the standard raknet license but I will have to go back and look at what I did. It's been a while.

On Fri, Jun 22, 2018, 3:22 PM Stefan Hett notifications@github.com wrote:

@kdavison https://github.com/kdavison: Due to lack of other means to contact you, posting this here as a comment:

I understand that you didn't put your pull request under a special license and hence in our understanding it's covered by the original RakNet license. Please let me know if I got this wrong and you rather considering your contributions under special license terms.

We applied the basic idea of your pull request in SLikeNet (available already in the GitHub and SVN repositories - changes are scheduled to be shipped in SLikeNet 0.2.0): https://github.com/SLikeSoft/SLikeNet

As a way to thank you for your contribution, we'd like to offer you putting you in the acknowledgments section of the accompanying readme for the next version:

kdavison: https://github.com/kdavison (pull request: RAKNET_93)

Please let me know if that's fine with you (preferably by mail to info [at] slikesoft [dot] com - or alternatively leave a comment here). Unless you explicitly say so, we won't put that entry in the readme file (to respect your privacy).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/facebookarchive/RakNet/pull/93#issuecomment-399570878, or mute the thread https://github.com/notifications/unsubscribe-auth/AF2R2O9HlhNzw1QqyUBaydmg7gARrSobks5t_VHxgaJpZM4H1yBf .