[Shimmer] fix shimmering speed doesn't update when frame change

facebookarchive / Shimmer

An easy way to add a simple, shimmering effect to any view in an iOS app.

Other

9.35k stars 1.11k forks source link

[Shimmer] fix shimmering speed doesn't update when frame change #48

Closed larrytjok closed 9 years ago

larrytjok commented 9 years ago

the if condition is always true, and that causes us never update the shimmering speed.

facebook-github-bot commented 9 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

facebook-github-bot commented 9 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

larrytjok commented 9 years ago

actually this is wrong =___=

grp commented 9 years ago

It looks like a real fix. Do you think this would be worth merging anyway?