Add Carthage support - Githubissues

facebookarchive / Shimmer

An easy way to add a simple, shimmering effect to any view in an iOS app.

Other

9.35k stars 1.11k forks source link

Closed klaaspieter closed 7 years ago

klaaspieter commented 7 years ago

Support Carthage by adding a framework scheme and target.

I'm aware there are two PRs (#53 and #55) open for this but they appear to be dead and have merge conflicts.

klaaspieter commented 7 years ago

@grp I made the requested changes squashed them into a single commit.

klaaspieter commented 7 years ago

@grp anything else that needs to happen for this to get merged?

klaaspieter commented 7 years ago

@grp the other two PRs adding this can be closed to probably.

bishalg commented 7 years ago

@klaaspieter : there is still issue wth Carthage and the issue has not been fixed !