search

facebookarchive / Shimmer

An easy way to add a simple, shimmering effect to any view in an iOS app.
Other
9.35k stars 1.11k forks source link

[ADD] Carthage Installation Guide on ReadMe file #75

Open bishalg opened 7 years ago

bishalg commented 7 years ago

Added Instructin to install Carthage and more steps on Cocopods Installation

facebook-github-bot commented 7 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

facebook-github-bot commented 7 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

grp commented 7 years ago

Rather than explain how to use the tools, could we link to the documentation of the tools themselves? That also makes sure it stays up to date even if the tool usage changes.

bishalg commented 7 years ago

@grp : I have seen most of the iOS framework adding Installation guide of carthage and cocoapod directly into main ReadMe file. In some reare case where the main ReadMe is huge they tend to add separate installation guide. example of some popular Swift frameworks -

grp commented 7 years ago

I tend to have an optimistic view that people would already know how to use their tools. :)

antonino-u commented 6 years ago

Unless I'm missing something, it seems that even on the latest stable Carthage 0.30.1, Shimmer can't be build by Carthage because Dependency "Shimmer" has no shared framework schemes.

bishalg commented 6 years ago

@antonino-u: there has been no development to the project in last 2 years so I don't think Carthage support would be possible, the only solution seems to be forking the project and maintaining it manually.