facebookarchive / account-kit-samples-for-ios

Samples for the account kit product on ios.
43 stars 26 forks source link

Login with phone: Country Code & localization not recognized #4

Closed hansemannn closed 8 years ago

hansemannn commented 8 years ago

Hey there,

while the Titanium Mobile module works fine now, I noticed that the country code supplied like below does not work. I would expect that one of de_DE, DE or de preselects the german phone country code +49. I didn't find anything related in the docs. Which ISO norm do you expect there? The AKFPhoneNumber class is missing all documentation, adding it there would be great.

In addition, in both the example and my generic module, the countries are not localized correctly by default. We need the bundle to localize the current language, but anyway it should fallback to a proper english-localized interface. Thanks!

simulator screen shot 16 04 2016 21 56 02 simulator screen shot 16 04 2016 21 56 05

olgaikuznetsova commented 8 years ago

Please note that this is the Github page for our samples project, not for the whole of AccountKit. Please file bugs/issues with AccountKit in our developer portal: https://developers.facebook.com/bugs/?tag_ids=1679169675664406

The AFKPhoneNumber reference is here: https://developers.facebook.com/docs/reference/ios/current/class/AKFPhoneNumber/

When you do file, a few questions 1) Are you referring to passing in a default country code or reading it from the device? 2) What language is the device running in?

Thanks!