[Scripts] Create icu and jsc dirs on first run, and bail out if scripts fail

facebookarchive / android-jsc

Scripts for building JSC for Android

Other

255 stars 38 forks source link

[Scripts] Create icu and jsc dirs on first run, and bail out if scripts fail #3

Closed ide closed 9 years ago

ide commented 9 years ago

Adds two small enhancements to the setup scripts:

Make the icu and jsc directories on the first run. Otherwise the tar command (on OS X at least) fails if the directories don't yet exist.
Add set -e to the scripts so that they bail out if any command fails

Test Plan: Run fetch_sources.sh in a clean repo and see it succeed. Run install.sh (which currently fails on the buck build step) and see it bails out on failure instead of going on to run the maven step.

ide commented 9 years ago

Actually, it looks like jsc/BUCK, jsc/extra_headers, and icu/BUCK should be included in this repo so the mkdir commands won't be necessary if that's accurate.

kmagiera commented 9 years ago

This is no longer required as those folders are under version control now as they contain project-specific build scripts. The've been somehow excluded from initial commit because of .gitignore

ide commented 9 years ago

I see the new commit, thanks. Do you still want the set -e changes?

kmagiera commented 9 years ago

Yeah, it would be good to add "set -e"