Add arm64 x86_64 support

facebookarchive / android-jsc

Scripts for building JSC for Android

Other

255 stars 38 forks source link

Add arm64 x86_64 support #30

Closed gengjiawen closed 5 years ago

gengjiawen commented 6 years ago

add arm64 x86_64 support
ci support (I switch to travis because they circle ci won't provide 8g machine for open source project)

Some bug in buck need to be fixed: https://github.com/facebook/buck/issues/1836. After they fix it. We need another pr to fix app modules thing.

rzsombor commented 6 years ago

How does this PR relate to https://github.com/facebook/android-jsc/pull/19 ?

gengjiawen commented 6 years ago

This pr is based on that pr, you can see the cherry commit from that pr. Besides that I fix broken url and add ci.

leeight commented 6 years ago

Cool.

LegNeato commented 6 years ago

The buck change landed: https://github.com/facebook/buck/commit/fe15dae213ac0e64886157cd513b043269f68edb

hramos commented 6 years ago

https://github.com/facebook/react-native/pull/18754 has been merged. What's next?

gengjiawen commented 6 years ago

Do you have merge permission to this repo ? we may still need a repo to handle jsc thing if we don't adopt the jsc from community.

AustinHunt commented 5 years ago

Is this ever happening?

hramos commented 5 years ago

This PR was opened as part of an effort to add 64-bit library support to React Nartive. We already have 64-bit support in the JSC that is being used by React Native. The JSC used there is built based on a different repository than this.

If you’re interested in seeing 64-bit support added to the JSC in this repository for use with something other than React Native, then I probably am not the right person to help.

AustinHunt commented 5 years ago

Well, the android version of React Native currently does not support Javascript Proxy...which is why I was using this JSC. But, this JSC does not work on Android 9 x86_64 devices.