facebookarchive / atom-ide-ui

A collection of user interfaces for Atom IDE.
http://ide.atom.io
Other
934 stars 79 forks source link

On-change providers not triggered on save #106

Open Arcanemagus opened 7 years ago

Arcanemagus commented 7 years ago

Description

Diagnostics providers that specify they update on document changes are not being triggered on saving the document.

Expected Behavior

All pull diagnostic providers for a document have a request sent to them for updates when the document is saved.

Actual Behavior

On-change pull diagnostic providers seem to be only triggered when the document is changed.

This causes problems as there is no way to trigger a re-lint of the document without changing the document. An example case where you would want to do this is if you change a configuration file and want to update the results to take into account the new configuration.

Versions

Additional Details

Installed packages ``` Community Packages (77) C:\Users\abneyl\.atom\packages ├── atom-beautify@0.30.5 ├── atom-ide-ui@0.5.3 ├── atom-material-ui@2.0.6 ├── autocomplete-lua@0.9.0 ├── busy-signal@1.4.3 (disabled) ├── docblockr@0.11.0 ├── editorconfig@2.2.2 ├── file-watcher@1.2.6 ├── highlight-selected@0.13.1 ├── ide-flowtype@0.17.4 ├── ide-php@0.6.9 ├── ide-python@0.2.2 ├── ide-typescript@0.6.2 ├── intentions@1.1.5 (disabled) ├── language-ansible@0.2.1 ├── language-chef@0.11.0 ├── language-cjson@0.0.1 ├── language-docker@1.1.8 ├── language-elixir@0.20.3 ├── language-erlang@3.2.0 ├── language-fortran@2.1.6 ├── language-gettext@0.6.1 ├── language-glsl@2.0.2 ├── language-haml@0.25.2 ├── language-haskell@1.14.3 ├── language-icinga2@0.3.0 ├── language-ini@1.19.0 ├── language-jade@0.7.2 ├── language-jolie@0.5.0 ├── language-kotlin@0.5.0 ├── language-livescript@0.0.3 ├── language-lua@0.9.11 ├── language-moonscript@1.7.1 ├── language-postcss@1.3.1 ├── language-powershell@4.0.0 ├── language-puppet@0.23.0 ├── language-r@0.4.2 ├── language-reg@0.0.0 ├── language-rust@0.4.12 ├── language-swift@0.5.0 ├── language-terraform@0.8.1 ├── language-vue@0.23.1 ├── linter@2.2.0 (disabled) ├── linter-coffeelint@1.3.1 ├── linter-eslint@8.4.0 ├── linter-flake8@2.2.1 ├── linter-htmlhint@1.3.4 ├── linter-js-standard@4.0.2 ├── linter-js-yaml@1.2.8 ├── linter-jsonlint@1.3.0 ├── linter-markdown@5.2.0 ├── linter-perl@0.8.1 ├── linter-perlcritic@2.0.0 ├── linter-php@1.5.1 ├── linter-phpcs@1.6.8 ├── linter-phpmd@2.0.0 ├── linter-proselint@3.3.0 ├── linter-pylama@0.9.4 ├── linter-pylint@2.1.0 ├── linter-rails-best-practices@0.2.2 (disabled) ├── linter-reek@2.2.2 ├── linter-rubocop@2.2.0 ├── linter-ruby@1.2.6 ├── linter-stylelint@4.0.2 ├── linter-tidy@2.3.1 ├── linter-ui-default@1.6.10 (disabled) ├── linter-ui-plus@0.3.2 (disabled) ├── mapfile-grammar@0.1.0 ├── minimap@4.29.7 ├── minimap-git-diff@4.3.1 ├── minimap-highlight-selected@4.6.1 ├── minimap-linter@2.1.3 ├── minimap-selection@4.5.0 ├── sequential-number@0.5.0 ├── sort-lines@0.18.0 ├── toggle-quotes@1.0.1 └── trailing-spaces@0.4.0 ```
Arcanemagus commented 6 years ago

Just discovered that on-save providers also aren't triggered on a save if the editor contents haven't changed. (Was testing exactly the scenario above: A changed configuration file.)