search

facebookarchive / atom-ide-ui

A collection of user interfaces for Atom IDE.
http://ide.atom.io
Other
936 stars 79 forks source link

Support for symbol rename? #145

Open rianneogi opened 6 years ago

rianneogi commented 6 years ago

Is there going to be support for symbol renaming via textDocument/rename?

exploide commented 6 years ago

related https://github.com/atom/atom-languageclient/issues/13

hansonw commented 6 years ago

We may look at this in the future, especially as we're considering adding additional refactoring APIs to the LSP (cc @hchau-fb). Nuclide has a generic refactoring UI we could bring in, but it's a bit overkill until the LSP has more than just rename.. I think we'd be open to someone implementing a really simple input dialog and exposing a rename service though. It depends on how @damieng and @daviwil want to prioritize this, I guess.

b-fuze commented 6 years ago

I'd like for this too... I wonder how hard it'd be to implement

arxanas commented 6 years ago

@ConderS implemented this during his internship! We did end up bringing in the generic refactoring UI as well. See https://gfycat.com/gifs/detail/PrestigiousWelldocumentedAldabratortoise for a preview.

damieng commented 5 years ago

How do we get this merged in so we can add support in atom-languageclient too?

arxanas commented 5 years ago

@damieng: It's already committed (e.g. in https://github.com/facebook-atom/atom-ide-ui/blob/master/modules/atom-ide-ui/pkg/atom-ide-refactor/lib/components/RenameComponent.js). Is that sufficient for your purposes?

Nuclide's LSP integration for rename is at https://github.com/facebook/nuclide/blob/ea943ace95f55de18eee60d3fe61cecabf5e1c9c/pkg/nuclide-vscode-language-service-rpc/lib/LspLanguageService.js#L1991