Testing, refactoring, and buffer size calculation

facebookarchive / augmented-traffic-control

Augmented Traffic Control: A tool to simulate network conditions

https://facebook.github.io/augmented-traffic-control

Other

4.33k stars 600 forks source link

Testing, refactoring, and buffer size calculation #326

Closed sheenobu closed 7 years ago

sheenobu commented 7 years ago

Must pin thrift to a given version.
Unmarshalling of empty group JSON was making acl list fail. unit tests confirm this.
errors.Wrap / errors.Wrapf helps provide more error context while errors.Cause can unwrap context.
dockerfile did not have iperf3
calculate buffer size based on RTT * Throughput
Updated documentation/ build.
Add dependency management via glide.

facebook-github-bot commented 7 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 7 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!