The old thrift setup used 'atc_thrift' and 'github.com/apache/thrift'
as imports, by building an internal GOPATH.
The current thrift setup uses:
'github.com/facebook/augmented-traffic-control/atc-thrift'
'github.com/apache/thrift'.
but this must be changed when using other build tooling.
Thrift just does not play well with go's hostname-based imports.
This setup uses the vendor folder to re-enable the naked
'atc_thrift' import. It also uses 'thrift/lib/go/thrift',
which allows it to be vendor agnostic.
chantra
commented
6 years ago
The old thrift setup used 'atc_thrift' and 'github.com/apache/thrift' as imports, by building an internal GOPATH.
The current thrift setup uses: 'github.com/facebook/augmented-traffic-control/atc-thrift' 'github.com/apache/thrift'.
but this must be changed when using other build tooling. Thrift just does not play well with go's hostname-based imports.
This setup uses the vendor folder to re-enable the naked 'atc_thrift' import. It also uses 'thrift/lib/go/thrift', which allows it to be vendor agnostic.