facebookarchive / bAbI-tasks

Task generation for testing text understanding and reasoning
Other
898 stars 183 forks source link

Generated data problematic for task 17 #2

Closed yujiali closed 9 years ago

yujiali commented 9 years ago

Similar to Issue #1 , data generated from task 17 also seems problematic. With the following command:

babi-tasks 17 10

Here is one generated problematic example:

1 The rectangle is below of the red square.
2 The red square is below of the rectangle.
3 The rectangle is above of the red square.
4 The pink rectangle is to the left of of the red square.
5 Is the rectangle below the red square?    no  2 1
6 Is the pink rectangle to the left of the rectangle?   yes 2 1
7 Is the pink rectangle above the rectangle?    no  2 1
8 Is the rectangle to the right of the pink rectangle?  yes 2 1
9 Is the rectangle above the red square?    yes 2 1
10 Is the rectangle below the red square?   no  2 1
11 Is the red square below the rectangle?   yes 2 1
12 Is the pink rectangle to the right of the red square?    no  2 1
bartvm commented 9 years ago

Fixed in https://github.com/facebook/bAbI-tasks/commit/7cdec59fac6968a53e96b5f5b9d6ef9748b42728, it shouldn't have output the second line.

yujiali commented 9 years ago

Thanks! That was quick.