search

facebookarchive / bAbI-tasks

Task generation for testing text understanding and reasoning
Other
897 stars 184 forks source link

babi/utilities.lua line 89: is this a bug? #3

Closed yujiali closed 8 years ago

yujiali commented 8 years ago 
function Grid:to_coordinates(i)
    return (i - 1) % self.width + 1, math.floor((i - 1) / 10) + 1
end

Should the number 10 here actually be self.width?

bartvm commented 8 years ago

Yes, seems like that was left over from when the Grid class still had a fixed size, fixed in https://github.com/facebook/bAbI-tasks/commit/0a7e05c79cdb85019e92503a0923c5112e14acbf.