search

facebookarchive / bAbI-tasks

Task generation for testing text understanding and reasoning
Other
898 stars 183 forks source link

updated babi to use torch.class instead of "require class" #6

Closed alexholdenmiller closed 8 years ago

alexholdenmiller commented 8 years ago

Per some internal bugs with the class package, rewrote babi tasks to use torch.class instead (and thus added some class/module structure as needed by the torch.class method)

ghost commented 8 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

ghost commented 8 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

alexholdenmiller commented 8 years ago

Added another commit which fixes https://github.com/facebook/bAbI-tasks/issues/7