search

facebookarchive / bistro

Bistro is a flexible distributed scheduler, a high-performance framework supporting multiple paradigms while retaining ease of configuration, management, and monitoring.
https://bistro.io
MIT License
1.03k stars 158 forks source link

Python 2 syntax error in scratch_test.py #35

Closed cclauss closed 5 years ago

cclauss commented 5 years ago

$ python2 -c "C:\users"

  File "<string>", line 1
    C:\users
     ^
SyntaxError: invalid syntax

On Python 3, this is not a syntax error.

$ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics

./build/fbcode_builder/getdeps/test/scratch_test.py:20:1: E999 SyntaxError: (unicode error) 'rawunicodeescape' codec can't decode bytes in position 2-3: truncated \uXXXX
                r"C:\users\alice\appdata\local\temp\fbcode_builder_getdeps",
^
1     E999 SyntaxError: (unicode error) 'rawunicodeescape' codec can't decode bytes in position 2-3: truncated \uXXXX
1
snarkmaster commented 5 years ago

Thanks, @cclauss — we'll get this fixed.

This isn't part of Bistro proper, but a shared "drop-in" called fbcode_builder that many FB projects use to build their open-source variants. So this Windows-specific test in no way affects Bistro, which only runs on Linux.

That said, I've reached out to the folks responsible for this file to get them to fix it.

I'll close it once it's fixed.

snarkmaster commented 5 years ago

Should be fixed now: https://github.com/facebook/bistro/commit/0a3f7b0073d4f42ba26ecb94d39b0fc7e0af71e0